Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for public Cloudflare DNS servers. #2075

Merged
merged 1 commit into from Apr 2, 2018
Merged

Add support for public Cloudflare DNS servers. #2075

merged 1 commit into from Apr 2, 2018

Conversation

everettsouthwick
Copy link
Contributor

@everettsouthwick everettsouthwick commented Apr 1, 2018

Signed-off-by: Everett Southwick everett@everettsouthwick.com

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

This pull request will add support for Cloudflare's new Public DNS servers (1.1.1.1 and 1.0.0.1) launched today.

Relevant issue:
#2072

How does this PR accomplish the above?:

It adds an option during install to choose Cloudflare's Public DNS servers.

What documentation changes (if any) are needed to support this PR?:

I'm not aware of any documentation changes that would be necessary.

Signed-off-by: Everett Southwick <everett@everettsouthwick.com>
Copy link
Contributor

@AzureMarker AzureMarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AzureMarker AzureMarker merged commit 1200a77 into pi-hole:development Apr 2, 2018
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/add-default-support-for-cloudflare-dns/8486/2

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/1-1-1-1/8472/5

@jacobsalmela
Copy link
Contributor

@everettsouthwick please contact me directly for a special thank you for contributing to our project.

@mibere
Copy link

mibere commented Apr 2, 2018

What about the corresponding IPv6 addresses?

2606:4700:4700::1111
2606:4700:4700::1001

@LilSnoop40
Copy link

any chance i can remove all DNS except cloudflare... can't figure it out from the web admin page

Thanks

@PromoFaux
Copy link
Member

Just add the cloudflare DNS servers to the Custom boxes, and untick the rest on the settings->DNS page of the web admin.

image

@LilSnoop40
Copy link

That is what i did and a few reboots of my router/pi-hole... any ideas?:
image

Thanks

@PromoFaux
Copy link
Member

@LilSnoop40 can you open a new issue, please? There may be other factors about your installation that are causing issues here. Please make sure you follow the new issue template and we'll hopefully be able to get to the bottom of it. Cheers.

@pi-hole pi-hole locked as resolved and limited conversation to collaborators Apr 2, 2018
@PromoFaux
Copy link
Member

@mibere see pi-hole/web#709

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/add-cloudflare-dns-servers/8780/5

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/cloudflare-upstream-dns-missing/10810/3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants