Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Pi-Hole header for nginx, and default page display #271

Closed
wants to merge 3 commits into from
Closed

Fixed Pi-Hole header for nginx, and default page display #271

wants to merge 3 commits into from

Conversation

ajgon
Copy link

@ajgon ajgon commented Jan 31, 2016

This is a continuation of the pull-request: #261

Igor Rzegocki and others added 2 commits January 28, 2016 20:56
Why? For the glory of satan of course...
Also, many people tends to use their PIs for multiple purposes. As mail
servers, webpage hosting etc. Usually in that cases nginx is used as far
more powerful alternative to lighttpd, and fair more lighter than
apache. This patch allows them to unleash the power of pi-hole without
too much hacking.

Also, I'm the one of those people, and needed it ;).
@dschaper
Copy link
Member

dschaper commented Feb 4, 2016

Thanks!!

@dschaper
Copy link
Member

Do we want to pursue this, using nginx? (I do, but I think it's lighter on resources...) Can we do a dual-install option, with the users being able to chose?

@dschaper
Copy link
Member

dschaper commented Mar 8, 2016

Haven't forgotten about this!

@ajgon
Copy link
Author

ajgon commented Mar 8, 2016

Still willing to help, if you need it :)

@dschaper
Copy link
Member

dschaper commented Mar 8, 2016

Awesome, thanks!

@dschaper
Copy link
Member

Can this be rebased off of Development?

@dschaper dschaper changed the base branch from Feature/ajgon-nginx to development August 17, 2016 19:14
@PromoFaux
Copy link
Member

@ajgon Once we've merged #814 into development, would you mind revisiting this?

@ajgon
Copy link
Author

ajgon commented Oct 31, 2016

@PromoFaux sure, just let me know.

@jacobsalmela
Copy link
Contributor

@ajgon #814 has been merged. Do you want to revisit?

@jacobsalmela jacobsalmela added the PR: Merge Conflict Issue blocking check and merge of code label Nov 12, 2016
@dschaper dschaper removed PR: Merge Conflict Issue blocking check and merge of code Testing Required labels May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants