Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lighttpd MIME related error. #2811

Closed
wants to merge 2 commits into from

Conversation

RamSet
Copy link
Member

@RamSet RamSet commented Jun 24, 2019

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Fixed issue related to lighttpd not starting/failing during install due to deprecated parameter in the config (migrated from older versions).

How does this PR accomplish the above?:
Commented out the old perl mime file path and hard coded generic MIME definitions within the config.

What documentation changes (if any) are needed to support this PR?:
None


  • You must follow the template instructions. Failure to do so will result in your pull request being closed.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.

Signed-off-by: RamSet <RamSet@gmail.com>
@RamSet RamSet changed the title Fix/lighttpd MIME related error. Fix lighttpd MIME related error. Jun 24, 2019
Signed-off-by: RamSet <RamSet@gmail.com>
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/getting-ready-for-buster/21001/19

@dschaper
Copy link
Member

Do we want this to go to development or should this be a point release branch to get out?

@AzureMarker
Copy link
Contributor

We can put it in a hotfix release. @RamSet, cherrypick your commits onto a new branch based off of master, and then make a PR against master.

@dschaper
Copy link
Member

Can he just rebase his branch off master?

@AzureMarker
Copy link
Contributor

Yes, that is functionally the same.

@dschaper
Copy link
Member

See #2816

@dschaper dschaper closed this Jun 25, 2019
@RamSet RamSet deleted the fix/lighttpdMime branch June 25, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants