Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force nameserver 127.0.0.1 through resolvconf #3031

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 9, 2019

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:

This is a proposed bug fix for #2535 and maybe a few others. As this is a breaking change, we might want to include it in v5.0 ?...

How does this PR accomplish the above?:

Remove calls to resolvconf within pihole-FTL's init.d script.

What documentation changes (if any) are needed to support this PR?:

Probably none.

@DL6ER DL6ER added the Bug: fixed Contains a bug resolution label Dec 9, 2019
@DL6ER DL6ER added this to the v5.0 milestone Dec 9, 2019
dschaper
dschaper previously approved these changes Dec 9, 2019
@PromoFaux PromoFaux merged commit 02f3316 into development Dec 11, 2019
@PromoFaux PromoFaux deleted the fix/do_not_force_local_resolver branch December 11, 2019 22:11
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-update-failure/27576/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: fixed Contains a bug resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants