Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store number of distinct gravity domains in database after counting #3115

Merged
merged 1 commit into from Feb 5, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 4, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Speed up FTL start and reload actions.

How does this PR accomplish the above?:

Precompute and store number of distinct gravity domains in database.

Connected FTL PR is pi-hole/FTL#688

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER added this to the v5.0 milestone Feb 4, 2020
@DL6ER DL6ER requested a review from a team February 4, 2020 20:34
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/disabling-pi-hole-breaks-dns-for-1-min/27492/31

@DL6ER DL6ER merged commit 37a44c0 into release/v5.0 Feb 5, 2020
@DL6ER DL6ER deleted the tweak/gravity_count branch February 5, 2020 22:25
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/discrepancy-among-displayed-domains-vs-real-domains/28491/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants