Remove wget from PIHOLE_DEPS #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/dependency-on-wget-in-basic-install-sh/28973/6 |
|
Thanks for the pull, there is also another |
|
Thanks, for the hint. Sorry for missing out that one. |
PromoFaux
previously approved these changes
Mar 1, 2020
All external calls have been moved to curl, wget no longer needed as dependency Signed-off-by: msamendinger <git@samendinger.de>
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
|
It has been accidentally re-added: 982c1b0#diff-595630a29a855f6d667a84ca0662042e826bf3ec56322ef61d4a6ef149147d23 Will open a new PR: #4153 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All external calls have been moved to curl, wget no longer needed as
dependency
Signed-off-by: msamendinger git@samendinger.de
By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]
git rebase)Please make sure you Sign Off all commits. Pi-hole enforces the DCO.
What does this PR aim to accomplish?:
A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues
Removes wget as dependency from auto installer.
How does this PR accomplish the above?:
A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix
Removes wget from PIHOLE_DEPS
What documentation changes (if any) are needed to support this PR?:
A detailed list of any necessary changes
None