Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect type description #3201

Merged
merged 1 commit into from Mar 8, 2020
Merged

Fix incorrect type description #3201

merged 1 commit into from Mar 8, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 8, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Fix incorrect type description in the v5.0 debugger.

How does this PR accomplish the above?:

Change description text as per https://deploy-preview-201--pihole-docs.netlify.com/database/gravity/#domain-tables-domainlist

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER
Fix incorrect type description.
63a1f63 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bug: fixed Contains a bug resolution label Mar 8, 2020
@DL6ER DL6ER added this to the v5.0 milestone Mar 8, 2020
@DL6ER DL6ER requested a review from dschaper March 8, 2020 10:07
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/unexpected-behaviour-while-blocking-whitelisting-with-similar-regex-rules/28791/19

@dschaper dschaper merged commit 22ce5c0 into release/v5.0 Mar 8, 2020
@dschaper dschaper deleted the fix/debugger_list_description branch March 8, 2020 23:32
dschaper added a commit that referenced this pull request Mar 8, 2020
@DL6ER @dschaper
Update development from release/v5.0 (#3200)
497bfd8 
* Use bash regex instead of awk.

Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>

* Fix incorrect type description. (#3201)

Signed-off-by: DL6ER <dl6er@dl6er.de>

Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschaper dschaper dschaper approved these changes

Assignees
No one assigned
Labels
Bug: fixed Contains a bug resolution
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DL6ER @pralor-bot @dschaper