Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web server question enhancements #3225

Merged
merged 1 commit into from
Oct 9, 2020
Merged

web server question enhancements #3225

merged 1 commit into from
Oct 9, 2020

Conversation

MichaIng
Copy link
Contributor

@MichaIng MichaIng commented Mar 23, 2020 •
edited
Loading

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Signed-off-by: MichaIng micha@dietpi.com

What does this PR aim to accomplish?:

  • When the web interface is not wanted, the web server install is obsolete, hence the question to install it not required.
  • When the web server is deselected during install, required PHP modules are not installed as well and the web server user is not added to the pihole group for database access through web UI. This needs to be instead done/assured manually by the user.

How does this PR accomplish the above?:

  • Do not ask to install the web server, if the web interface has been deselected before.
  • Add additional info, that PHP modules need to be installed manually, when web server is deselected and the web server user needs to be member of the "pihole" group.

StackNeverFlow
StackNeverFlow previously approved these changes Mar 25, 2020
View reviewed changes
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/error-message-attempt-to-write-a-readonly-database/27092/29

DL6ER
DL6ER requested changes Apr 28, 2020
View reviewed changes
automated install/basic-install.sh Outdated Show resolved Hide resolved
@DL6ER DL6ER added the PR: Merge Conflict Issue blocking check and merge of code label May 5, 2020
@MichaIng MichaIng mentioned this pull request May 7, 2020
Closed
3 tasks
@MichaIng
web server question enhancements
6aecccf 
+ Do not ask to install the web server, if the web interface has been deselected before.
+ Add additional info, that PHP modules need to be installed manually, when web server is deselected and the web server user needs to be member of the "pihole" group.
+ Consequently use webroot variable instead of /var/www/html

Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng MichaIng requested a review from DL6ER May 10, 2020 11:24
@MichaIng
Copy link
Contributor Author

@DL6ER
Conflicts have been resolved and your requested changes have been added. What do you think?
Considering the amount of help requests in the forum around Nginx and Apache webserver systems, I think the additional information would be great to have with next release 🙂.

@yubiuser yubiuser mentioned this pull request May 16, 2020
Closed
3 tasks
@MichaIng MichaIng mentioned this pull request Jul 21, 2020
Closed
8 tasks
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/raspberry-pi-os-support/39087/24

@PromoFaux PromoFaux self-requested a review October 9, 2020 13:10
@PromoFaux
Copy link
Member

I'll wait for approval from @DL6ER to merge this, though. As I see he requested changes

@DL6ER DL6ER merged commit 615b19c into pi-hole:development Oct 9, 2020
@MichaIng MichaIng deleted the patch-7 branch October 9, 2020 14:20
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

@DL6ER DL6ER DL6ER approved these changes

@StackNeverFlow StackNeverFlow StackNeverFlow left review comments

Assignees
No one assigned
Labels
PR: Merge Conflict Issue blocking check and merge of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MichaIng @pralor-bot @PromoFaux @DL6ER @StackNeverFlow