Improve conditional forwarding #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intended CIDR range automatically. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
dschaper
reviewed
May 20, 2020
|
What is the status on this please? |
…the shellcheck rule. Signed-off-by: DL6ER <dl6er@dl6er.de>
|
@PromoFaux Merged in the most recent changes, resolved all conflicts. I think this is good to go. |
… The code does now preserve legacy behavior and users can open up the subnet manually if they like. Signed-off-by: DL6ER <dl6er@dl6er.de>
dschaper
approved these changes
Jun 21, 2020
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
Improve conditional forwarding
How does this PR accomplish the above?:
Necessary backend changes with automatic conversion of existing legavy settings into the new format. More details may be found in pi-hole/web#1208
What documentation changes (if any) are needed to support this PR?:
None