Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #3312

Merged
merged 1 commit into from
May 1, 2020
Merged

Remove dead code #3312

merged 1 commit into from
May 1, 2020

Conversation

subdavis
Copy link
Contributor

@subdavis subdavis commented May 1, 2020

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code. NA
  • I have tested my proposed changes, and have included unit tests where possible. NA
  • I am willing to help maintain this change if there are issues with it later. NA
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Removes an apparently nonsense directory containing files with no references anywhere and no documentation to explain why they exist. They have hard-coded IPs and files apparently specific to some developer's home network.

How this has managed to survive here for 4 years is astonishing.

How does this PR accomplish the above?:

Removes spooky files.

What documentation changes (if any) are needed to support this PR?:

None.


  • You must follow the template instructions. Failure to do so will result in your pull request being closed.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.

Signed-off-by: Brandon Davis <git@subdavis.com>
@PromoFaux
Copy link
Member

I think there was an effort a long time ago to build in something that worked with Hulu ads, obviously long since abandoned.

Happy to remove, but please dial back the snark ;)

@PromoFaux PromoFaux merged commit 4710963 into pi-hole:development May 1, 2020
@subdavis
Copy link
Contributor Author

subdavis commented May 1, 2020

Happy to remove, but please dial back the snark ;)

Sorry, please interpret snark as amused bewilderment rather than hostility toward maintainers. Ya'll are awesome, thanks for all the hard work.

@subdavis subdavis deleted the development branch May 5, 2020 01:43
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants