Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement backend support for theming #3327

Merged
merged 1 commit into from
May 12, 2020
Merged

Implement backend support for theming #3327

merged 1 commit into from
May 12, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 10, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Add support for pi-hole/web#1253

How does this PR accomplish the above?:

Add pihole -a theme option.

What documentation changes (if any) are needed to support this PR?:

None

Note that the target branch needs to be changed from master to devel once #3324 is merged.

@DL6ER DL6ER added Enhancement Feature Request: Discourse Implements a Feature Request from Discourse labels May 10, 2020
@DL6ER DL6ER added this to the v5.1 milestone May 10, 2020
@PromoFaux PromoFaux changed the base branch from master to development May 12, 2020 21:00
@PromoFaux PromoFaux changed the base branch from development to master May 12, 2020 21:00
@PromoFaux
Copy link
Member

Oh dear. Rebase on development and submit against the development branch please ;)

@DL6ER DL6ER changed the base branch from master to development May 12, 2020 21:02
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Copy link
Member Author

DL6ER commented May 12, 2020

@PromoFaux Well, see my last sentence in the description - I missed it. Done now.

@PromoFaux PromoFaux self-requested a review May 12, 2020 21:18
@DL6ER DL6ER merged commit a1e913d into development May 12, 2020
@DL6ER DL6ER deleted the new/dark branch May 12, 2020 21:19
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature Request: Discourse Implements a Feature Request from Discourse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants