Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown tweaks #3420

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Markdown tweaks #3420

merged 1 commit into from
Jun 30, 2020

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 21, 2020

Signed-off-by: XhmikosR xhmikosr@gmail.com

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


There shouldn't be any changes in the rendered file, apart from the header callout and the code snippets. Regarding the former, I used what we have in the docs repo so that we are consistent.

This might conflict with #3412, so I'm marking it as draft and I'll rebase when that's merged.

@XhmikosR XhmikosR requested a review from dschaper May 31, 2020 03:45
@XhmikosR XhmikosR marked this pull request as ready for review May 31, 2020 03:45
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
@XhmikosR XhmikosR requested a review from PromoFaux June 4, 2020 13:25
@dschaper dschaper merged commit 56e0549 into pi-hole:development Jun 30, 2020
@XhmikosR XhmikosR deleted the XhmikosR-patch-4 branch July 1, 2020 05:38
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants