Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display warning if unsupported OS is detected #3441

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

This adds an additional check to the top of the install script to determine whether or not the script is being invoked on a supported system.

Unsupported OS message:
image

Unsupported - but user acknowledged - message:
image

Supported OS Message:
image

As discussed in #3421

…ing run on a supported OS

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux requested review from dschaper and DL6ER May 25, 2020 16:43
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@dschaper
Copy link
Member

dschaper commented Jun 5, 2020

Same changes here as on #3434

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@dschaper dschaper merged commit 4b59287 into development Jun 5, 2020
@dschaper dschaper deleted the new/os_check branch June 5, 2020 20:39
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/unsupported-os-error-when-upgrading-to-5-1/35630/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants