Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase
)What does this PR aim to accomplish?:
The newly added os_check works fine if
dig
is already installed... I guess one thing we did not test was a fresh installation!This PR moves the call to the
os_check
function to after the installer dependencies are installed, and also movesbind-utils
(yum
) anddnsutils
(apt
) to the installer dependenciesIf we want to have this at the top of the installer, then we will not be able to use the
TXT
record onversions.pi-hole.net
, and instead will need tocurl
the same information from somewhere else.