Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new os_check #3490

Merged
merged 1 commit into from Jun 13, 2020
Merged

Fix new os_check #3490

merged 1 commit into from Jun 13, 2020

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

The newly added os_check works fine if dig is already installed... I guess one thing we did not test was a fresh installation!

This PR moves the call to the os_check function to after the installer dependencies are installed, and also moves bind-utils (yum) and dnsutils (apt) to the installer dependencies

If we want to have this at the top of the installer, then we will not be able to use the TXT record on versions.pi-hole.net, and instead will need to curl the same information from somewhere else.

…rted after installing installer deps

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux added the Bug: fixed Contains a bug resolution label Jun 13, 2020
@PromoFaux PromoFaux added this to the v5.1 milestone Jun 13, 2020
@PromoFaux PromoFaux requested review from dschaper and DL6ER June 13, 2020 20:42
@PromoFaux PromoFaux added the Priority: High Urgent issues and Feature Requests label Jun 13, 2020
@PromoFaux PromoFaux merged commit b96ce13 into development Jun 13, 2020
@PromoFaux PromoFaux deleted the fix_os_check branch June 13, 2020 23:24
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

@PromoFaux PromoFaux mentioned this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: fixed Contains a bug resolution Priority: High Urgent issues and Feature Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants