Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(README.md): Grammar fix #3581

Merged
merged 1 commit into from
Jul 20, 2020
Merged

chore(README.md): Grammar fix #3581

merged 1 commit into from
Jul 20, 2020

Conversation

jokajak
Copy link
Contributor

@jokajak jokajak commented Jul 19, 2020

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Fix small grammar issue in README.md

How does this PR accomplish the above?:
Fix small grammar issue in README.md

What documentation changes (if any) are needed to support this PR?:
None


  • You must follow the template instructions. Failure to do so will result in your pull request being closed.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.

@dschaper dschaper added the PR: Master branch PR based on Master Branch label Jul 19, 2020
@dschaper
Copy link
Member

Thanks for the submission, please follow step one of the contributors guide.

https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md#technical-requirements

@jokajak jokajak changed the base branch from master to development July 20, 2020 19:46
Fix small grammar issue in README.md

Signed-off-by: Jokajak <jokajak@gmail.com>
@jokajak
Copy link
Contributor Author

jokajak commented Jul 20, 2020

Looks like I missed the technical steps the first time through.

@dschaper dschaper removed the PR: Master branch PR based on Master Branch label Jul 20, 2020
@dschaper dschaper merged commit b0ea043 into pi-hole:development Jul 20, 2020
@jokajak jokajak deleted the patch-1 branch July 21, 2020 02:21
@PromoFaux PromoFaux mentioned this pull request Aug 4, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants