Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "About Pi-hole" link on "Website Blocked" page #3639

Merged

Conversation

nfriend
Copy link
Contributor

@nfriend nfriend commented Aug 2, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:

Updates the About Pi-hole link found on the Website Blocked page:

Screen Shot 2020-08-01 at 7 55 35 PM

Currently, this link points to https://github.com/pi-hole/pi-hole/wiki/What-is-Pi-hole%3F-A-simple-explanation, which redirects to https://github.com/pi-hole/pi-hole/wiki, which instructs the user to instead visit https://docs.pi-hole.net/.

This PR updates the link to point directly to https://docs.pi-hole.net/.

How does this PR accomplish the above?:

Updates the hard-coded About Pi-hole link in advanced/index.php.

What documentation changes (if any) are needed to support this PR?:

None.

Signed-off-by: Nathan Friend <nathan@gitlab.com>
@dschaper dschaper merged commit 72df833 into pi-hole:development Aug 2, 2020
@PromoFaux PromoFaux mentioned this pull request Aug 4, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants