Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for free disk space and associated variables #3698

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Remove check for free disk space and associated variables #3698

merged 1 commit into from
Sep 21, 2020

Conversation

yubiuser
Copy link
Member

Removes the check for free disk space (~52MB was required) and associated variables.
The check was introduced here: #301.

Removal discussion here pi-hole/docs#364 (comment)

Signed-off-by: Christian König <ckoenig@posteo.de>
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm largely OK with this PR in principle. It also gets rid of a nearly-useless undocumented flag.

Requesting secondary review from @dschaper or @DL6ER before merging

@dschaper
Copy link
Member

I haven't tested or checked for actual function but the concept is okay by me.

@PromoFaux PromoFaux merged commit d6c4f06 into pi-hole:development Sep 21, 2020
@PromoFaux
Copy link
Member

(I tested before merge, btw!)

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

@yubiuser yubiuser deleted the remove/FreeSpaceCheck branch August 9, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants