Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date_updated field to adlist table #3740

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 7, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Screenshot at 2020-09-07 21-17-10

How does this PR accomplish the above?:

Add a new date_updated field to adlist table. This field is preserved if we used a cached version and updated when we downloaded new content.

What documentation changes (if any) are needed to support this PR?:

Add description of additional field to the database table description (to be done separately)

This PR is connected to pi-hole/web#1579

…ated column to now but use NULL instead

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bug: fixed Contains a bug resolution label Sep 7, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/last-modified-for-adlists-should-display-modification-date-of-adlist-instead-of-database-modification/35204/7

@PromoFaux PromoFaux merged commit 948337d into development Oct 9, 2020
@PromoFaux PromoFaux deleted the new/adlist_date_updated branch October 9, 2020 13:04
# Add column date_updated to alist table
echo -e " ${INFO} Upgrading gravity database from version 12 to 13"
sqlite3 "${database}" < "${scriptPath}/12_to_13.sql"
version=12
Copy link
Contributor

@MichaIng MichaIng Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PromoFaux
I guess this should have been version=13? 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

innocent whistling

#3788

@PromoFaux PromoFaux mentioned this pull request Oct 9, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/unable-to-fill-table-adlist-in-database-etc-pihole-gravity-db/41116/14

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/blocklist-show-last-modified-date/30878/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: fixed Contains a bug resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants