Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print tail of logs in /var/log/lighttpd in debug run as well #3776

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Print tail of logs in /var/log/lighttpd in debug run as well #3776

merged 2 commits into from
Oct 9, 2020

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 2, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Print tail of logs in /var/log/lighttpd in debug run as well. Currently, only the first 25 lines are printed which might be not enough if a lot of errors occurred and older ones are different than newer ones.

How does this PR accomplish the above?:
Use head_tail_log function (which is also used for /var/log/pihole-FTL.log

Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@PromoFaux PromoFaux merged commit 716e981 into pi-hole:development Oct 9, 2020
@yubiuser yubiuser deleted the tweak/Debug branch October 9, 2020 13:23
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants