Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native ARMv4T, ARMv5TE and ARMv8-A support #3801

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Add native ARMv4T, ARMv5TE and ARMv8-A support #3801

merged 1 commit into from
Oct 18, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 13, 2020 •
edited
Loading

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Add support for pre-compiled ARMv4R, ARMv5TE and ARMv8-A FTL binaries

How does this PR accomplish the above?:

Improve detection and add new criteria

Dependencies of this PR

This PR depends on pi-hole/docker-base-images#31 (:heavy_check_mark:) and should be merged at the same time as pi-hole/FTL#903 (already approved)
What documentation changes (if any) are needed to support this PR?:

None

@PromoFaux
Copy link
Member

PromoFaux commented Oct 13, 2020 •
edited
Loading

I think you also will need to fix up the tests for these, too.

e.g https://github.com/pi-hole/pi-hole/blob/development/test/test_automated_install.py#L190

@DL6ER
Improve processor detection to use the new dedicated ARMv4T, ARMv5TE …
01c9bbd 
…and ARMv8-A binaries we provide for FTL.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Copy link
Member Author

DL6ER commented Oct 14, 2020

Had to force-push once again to trigger the Travis build (it was always picking the second last commit, otherwise)

@DL6ER
Copy link
Member Author

DL6ER commented Oct 14, 2020

@PromoFaux Tests are all ✔️

@DL6ER DL6ER marked this pull request as ready for review October 14, 2020 19:12
@DL6ER DL6ER added Feature Request: Discourse Implements a Feature Request from Discourse PR: Approval Required Open Pull Request, needs approval labels Oct 14, 2020
@DL6ER DL6ER requested review from dschaper and removed request for dschaper October 18, 2020 17:26
@DL6ER
Copy link
Member Author

DL6ER commented Oct 18, 2020

pi-hole/FTL#903 should be merged (already approved) immediately after merging this PR

@PromoFaux
Copy link
Member

I'll let you do the honours!

@DL6ER DL6ER merged commit 83f2e2d into development Oct 18, 2020
@DL6ER DL6ER deleted the new/armv4_armv5_armv8 branch October 18, 2020 17:53
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-ftl-for-armv5l-precompiled/32645/2

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

@dschaper dschaper added this to the v5.2 milestone Dec 16, 2020
@dschaper dschaper added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Dec 16, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/ftl-install-failure-on-change-of-ip-address/41592/16

@yubiuser yubiuser mentioned this pull request Aug 12, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

@dschaper dschaper Awaiting requested review from dschaper

Assignees
No one assigned
Labels
Feature Request: Discourse Implements a Feature Request from Discourse PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Milestone
v5.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DL6ER @PromoFaux @pralor-bot @dschaper