Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to privacy level 4 (no longer functional) #3803

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Closes #3802

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Copy link
Member

@dschaper dschaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like Dom's approval before merging in. It makes sense to me but it seems like something we shouldn't have missed and maybe there's a reason we didn't.

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just too many places in the code where this was written. With level 4, blocking doesn't work because we cannot look up a donation in the database when we do not process the queries in the first place. This was possible before v5, because we loaded all domains into the DNS cache.

@DL6ER DL6ER merged commit e93d7ad into development Oct 14, 2020
@DL6ER DL6ER deleted the privacylevel branch October 14, 2020 05:05
@PromoFaux
Copy link
Member Author

because we cannot look up a donation in the database

Did your phone autocorrect domain to donation??

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants