Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon from cross to [i] for root user check #3825

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Change icon from cross to [i] for root user check #3825

merged 1 commit into from
Nov 15, 2020

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 29, 2020

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Change the icon from cross to [i] when performing root user check. As discussed here

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser changed the title Change icon from cross to [i]# for root user check Change icon from cross to [i] for root user check Oct 29, 2020
@dschaper
Copy link
Member

I think this needs to stay a cross. You can not run the script as non-sudo so it is indeed an error.

@yubiuser
Copy link
Member Author

At this points it just informs the user that it needs root privileges, the check for sudo comes a few lines later and will fail if sudo does not exist.

@dschaper
Copy link
Member

Yes, it's still an error.

@DL6ER
Copy link
Member

DL6ER commented Nov 2, 2020

I agree with @yubiuser about this change. If the user runs this as non-root (the typical scenario), it will just re-curl and sudo bash the installer. If this does not work (because the user doesn't know their password, etc.), sudo will give them a much more useful output. If sudo is not available, the user will be informed about this fact (and a cross is shown).

Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PromoFaux PromoFaux merged commit bd6ca0a into pi-hole:development Nov 15, 2020
@yubiuser yubiuser deleted the tweak/cross branch November 15, 2020 20:54
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/error-non-root-privileges-why-does-this-always-happen/42091/11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants