Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some output to the --nuke command #3847

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Add some output to the --nuke command #3847

merged 1 commit into from
Nov 17, 2020

Conversation

PromoFaux
Copy link
Member

@PromoFaux PromoFaux commented Nov 16, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Addresses #3845

output after PR:

image

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be

Removed ${count} domain(s) from the ${listname}

?

Also, why printing the number two times? Maybe

Removed all domains from ...

@PromoFaux
Copy link
Member Author

the ${listname}

I agree with that, oversight on my part.

What I was going for with the latter was to say "there are n number of domains in total on the ${listname}, and now I have removed n domains", rather than just "I removed some domains" I think it would probably make more sense with some if conditions in there and a check after the delete command has run.. but likely overkill

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux
Copy link
Member Author

Force pushed some changes

image

@PromoFaux PromoFaux merged commit c64b96e into development Nov 17, 2020
@PromoFaux PromoFaux deleted the fix/nuke branch November 17, 2020 09:26
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants