Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the raw messages from the Pi-hole diagnosis systems in debug logs #3862

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 24, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Include the raw messages from the Pi-hole diagnosis systems in debug logs

Example from an incorrect regex on the web interface:
Screenshot at 2020-11-24 16-05-06

and now in the debugger:
Screenshot at 2020-11-24 16-04-31

The interpretation of the five blob columns varies between message types. We do not do pretty formatting in the debugger to avoid having to change it for each new type of message we add (we currently have to do this already for the dashboard formatting). The mere existence of lines in here gives a hint that something is odd.

How does this PR accomplish the above?:

Add appropriate sqlite3 command to the debugger

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER added PR: Approval Required Open Pull Request, needs approval Debugging labels Nov 24, 2020
@DL6ER DL6ER requested a review from a team November 24, 2020 15:11
@PromoFaux PromoFaux merged commit 40ae29f into development Nov 28, 2020
@PromoFaux PromoFaux deleted the tweak/debugger_message branch November 28, 2020 16:51
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debugging PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants