Update pihole-FTL man-pages #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that PR, but note all PRs should be filed against |
DL6ER
requested changes
Dec 1, 2020
|
I also adjusted the description of the arguments to be consistent with the other sub-commands and updated the man-page date that I forgot before. |
DL6ER
previously approved these changes
Dec 1, 2020
DL6ER
reviewed
Dec 2, 2020
|
Is there still anything missing? |
|
You'll need to actually rebase on |
Ensure that all configuration options currently recognized by FTL 5.3.1 are properly documented in the man page of the configuration file. Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch>
Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch>
Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch>
Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch>
ganto
force-pushed
the
fix/update-ftl-conf-manpage
branch
from
b100757
to
ebad56e
Compare
Thanks, I didn't get that. Done now. |
|
Thanks, can you also squash the 4 commits? It helps keep things clean. |
DL6ER
approved these changes
Dec 10, 2020
|
I'll squash it for him. |
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-2-and-ftl-v5-3-3-released/41998/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
Ensure that all (configuration) options currently recognized by FTL 5.3.1 are properly documented in their corresponding man-pages.
How does this PR accomplish the above?:
Adding the missing configuration options read from currently released FTL's src/config.c as well as the runtime options read from the output of
pihole-FTL --helpWhat documentation changes (if any) are needed to support this PR?:
This is a documentation change.