Exit installer if directory already exists when trying to clone one of our repos into it #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ODO: Something more robust Signed-off-by: Adam Warner <me@adamwarner.co.uk>
dschaper
reviewed
Dec 2, 2020
PromoFaux
force-pushed
the
tweak/dontdelete
branch
from
e602c3a
to
641951b
Compare
dschaper
approved these changes
Dec 2, 2020
DL6ER
reviewed
Dec 2, 2020
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
DL6ER
approved these changes
Dec 2, 2020
dschaper
approved these changes
Dec 2, 2020
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-1-and-ftl-v5-3-2-released/41148/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
Rather than deleting the directory, return 1 so that the installer knows to throw up the error message and halt the install