piholeDebug: Diagnose output if (Web) git directory is not found #3904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase
)What does this PR aim to accomplish?:
If Pi-hole was installed without Web interface the
piholeDebug.sh
currently omits any output in the version check for the "Web" component:I guess it would be helpful to have more details what's up with the "Web" component.
How does this PR accomplish the above?:
I adjusted the code to print a note when the "Web" component has been disabled on purpose:
And I also added a proper error message if the git directory is not found. This works for all the components tested in
compare_local_version_to_git_version()
. Here an example output ifINSTALL_WEB_INTERFACE=true
(or missing) in thesetupVars.conf
:What documentation changes (if any) are needed to support this PR?:
No changes needed.