Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra failure display when installation of logrotate file is skipped because the file already exists #4247

Merged
merged 1 commit into from Jul 30, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 28, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Remove extra failure display when installation of logrotate file is skipped because the file already exists.

How does this PR accomplish the above?:

Just ensure that the script is not killed by set -e

What documentation changes (if any) are needed to support this PR?:

None

…kipped because the file already exists

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team July 28, 2021 20:16
@DL6ER DL6ER merged commit 9ae6b40 into release/v5.4 Jul 30, 2021
@DL6ER DL6ER deleted the tweak/installLogrotateFail branch July 30, 2021 05:44
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants