Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On enabling/disabeling only reload-lists instead of reload #4264

Merged
merged 1 commit into from Aug 9, 2021
Merged

On enabling/disabeling only reload-lists instead of reload #4264

merged 1 commit into from Aug 9, 2021

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 6, 2021

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
When blocking is enabled/disabled pihole restartdns reload was executed. Changing to pihole restartdns reload-lists should be sufficient and minimize restart time as well as preserve DNS cache.

Inspired by https://discourse.pi-hole.net/t/why-are-dhcp-leases-reconfirmed-when-disabling-and-enabling-blocking/48720

Signed-off-by: Christian König <ckoenig@posteo.de>
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this does only work with the latest FTL beta (pi-hole/FTL@d0ecd74)

@yubiuser yubiuser added PR: Approval Required Open Pull Request, needs approval PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Aug 8, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/why-are-dhcp-leases-reconfirmed-when-disabling-and-enabling-blocking/48720/10

@DL6ER DL6ER merged commit e163ed4 into pi-hole:release/v5.4 Aug 9, 2021
@yubiuser yubiuser deleted the tweak_enable branch August 9, 2021 16:27
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants