Perform a check of required packages befor updating pihole #4326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase
)Please make sure you Sign Off all commits. Pi-hole enforces the DCO.
Follow up of #4274
For discussion.
What does this PR aim to accomplish?:
Fixes rare edge cases like #2866
If users have removed packages that are part of
INSTALLER_DEPS
(e.g. git),pihole -up
will fail.This PR re-uses the
install_dependent_packages "${INSTALLER_DEPS[@]}"
from the installer script to check, and if necessary, install the missing packages.