Allow users to skip setting static IP adress #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian König <ckoenig@posteo.de>
PromoFaux
requested changes
Nov 1, 2021
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
PromoFaux
approved these changes
Nov 6, 2021
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1 |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/using-pi-hole-dns-resolution-on-pi-hole-host-system/52579/8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase)Please make sure you Sign Off all commits. Pi-hole enforces the DCO.
What does this PR aim to accomplish?:
On distribution using
dhcpdwe offer users to set a static IP during Pi-hole installation. However, the current implementation forces users with/etc/dhcpcd.confto set a static IP (take the current or set one manually). There was no way to circumvent this during setup.This PR adds a third option, to not set any static IP even if
/etc/dhcpcd.confexists.Fixes #4418
Additionally, the PR moves the IP selection to a earlier time point in the installer (before selecting upstream and blocklist) as the welcome warning about the necessity of a static IP address might still be more present.