Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the exemption issue label pinned to internal for stale issues #4558

Merged
merged 2 commits into from Jan 16, 2022

Conversation

yubiuser
Copy link
Member

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Change the exemption issue label pinned to internal for stale issues. We don't use the label pinned, but internal

Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@PromoFaux
Copy link
Member

Pinned, in this case, means that the issue is pinned to the top of the page, not a label.

We can add internal as an additional, though, for sure.

@yubiuser
Copy link
Member Author

Pinned, in this case, means that the issue is pinned to the top of the page, not a label.

Do you have any reference for this? I was looking for this, but the only case I found was after others explicitly added pinned as a label...

@PromoFaux
Copy link
Member

Oh, no reference - all based on assumption.

@yubiuser
Copy link
Member Author

yubiuser commented Jan 13, 2022

Try searching for issues with label:pinned yields nothing, even though one is currently pinned...

@dschaper dschaper self-requested a review January 13, 2022 08:52
@PromoFaux PromoFaux merged commit 3cd662e into master Jan 16, 2022
@PromoFaux PromoFaux deleted the stale branch January 16, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants