Exit installer if dpkg lock is held for more then 30 seconds #4682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase
)Please make sure you Sign Off all commits. Pi-hole enforces the DCO.
What does this PR aim to accomplish?:
Fixes #3977.
When installing via
apt
we use a function to check ifdpkg
is holding a lock on/va/lib/dpkg/lock
. If so we wait...until the lock is lifted. If there is no lifting we wait until forever.This PR adds a safety check to stop the whole installer if the lock is not lifted within 30 seconds.The original PR #1286 already introduced a counter but never used it. We do use it now.
P.S. The PR additionally moves the function
test_dpkg_lock
out ofpackage_manager_detect
because it is not used in there. (Only later ininstall_dependent_packages
)