-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for custom DNS server with port number #4718
Conversation
Signed-off-by: sed-i <82407168+sed-i@users.noreply.github.com>
Hi, can you make sure your commits and PR target are the correct branch. The contributors guide has the information. |
Thanks @dschaper. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ sudo grep -Irn "127\.0\.0\.1#5335" /etc
/etc/pihole/setupVars.conf:4:PIHOLE_DNS_1=127.0.0.1#5335
/etc/pihole/setupVars.conf:5:PIHOLE_DNS_2=127.0.0.1#5335
/etc/dnsmasq.d/01-pihole.conf:38:server=127.0.0.1#5335 However, I do not know at the moment how to test this: pi-hole/docs#695 |
Thanks for testing |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1 |
By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]
git rebase
)Please make sure you Sign Off all commits. Pi-hole enforces the DCO.
What does this PR aim to accomplish?:
A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues
Provide an example for how to specify a custom DNS address including a port number.
How does this PR accomplish the above?:
A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix
Update a string.
What documentation changes (if any) are needed to support this PR?:
A detailed list of any necessary changes
None.