Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in README.md #4818

Merged
merged 5 commits into from
Oct 15, 2022
Merged

Fix errors in README.md #4818

merged 5 commits into from
Oct 15, 2022

Conversation

Rauf00
Copy link
Contributor

@Rauf00 Rauf00 commented Jul 11, 2022

Signed-off-by: Rauf Shimarov 55862995+Rauf00@users.noreply.github.com

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

  • What does this PR aim to accomplish?:
    The README.md contains some grammatical errors and can be made more concise.

  • How does this PR accomplish the above?:
    a. Line 19, it might be not clear to which “process” the sentence is referring. Also, make it explicit that it is the installation process that “takes less than ten minutes”, not the installer itself
    b. Line 23, 133, “command line” is missing a hyphen
    c. Line 61, the sentence is too long and should be split into two to have better readability
    d. Line 71, “open source” is missing a hyphen
    e. Line 135, a wrong preposition “of” is used

  • What documentation changes (if any) are needed to support this PR?:
    The documentation needs to be changed according to the suggested corrections described above


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Rauf Shimarov <55862995+Rauf00@users.noreply.github.com>
@PromoFaux PromoFaux changed the base branch from master to development July 11, 2022 19:53
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Adam Warner <github@adamwarner.co.uk>

Signed-off-by: Rauf Shimarov <55862995+Rauf00@users.noreply.github.com>
Co-authored-by: Adam Warner <github@adamwarner.co.uk>

Signed-off-by: Rauf Shimarov <55862995+Rauf00@users.noreply.github.com>
@Rauf00 Rauf00 requested a review from PromoFaux July 11, 2022 23:00
Signed-off-by: Rauf Shimarov <55862995+Rauf00@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
@yubiuser yubiuser added the Submitter Attention Required Need action from submitter to continue label Sep 27, 2022
Signed-off-by: Adam Warner <github@adamwarner.co.uk>
@PromoFaux PromoFaux merged commit bc471cb into pi-hole:development Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Submitter Attention Required Need action from submitter to continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants