Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend FTL information in debug log #4864

Merged
merged 1 commit into from Aug 8, 2022
Merged

Extend FTL information in debug log #4864

merged 1 commit into from Aug 8, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 8, 2022

What does this PR aim to accomplish?:

Include branch and commit from FTL in debug log.

Before:
Bildschirmfoto zu 2022-08-08 13-31-52

After:
Bildschirmfoto zu 2022-08-08 13-50-14
Bildschirmfoto zu 2022-08-08 13-51-10

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Extend FTL information in debug log
d776773 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Aug 8, 2022
PromoFaux
PromoFaux approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems like a no-brainer to me

@yubiuser yubiuser merged commit a0419bc into development Aug 8, 2022
@yubiuser yubiuser deleted the debug_FTL_branch branch August 8, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

Assignees
No one assigned
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yubiuser @PromoFaux