Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Amazon support URL to HTTPS in README #4954

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

davidjb
Copy link
Contributor

@davidjb davidjb commented Sep 30, 2022

Signed-off-by: David Beitey david@davidjb.com

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

  • What does this PR aim to accomplish?:

Updates the Amazon affiliate link the readme to HTTPS to avoid a browser security warning on click.

  • How does this PR accomplish the above?:

By changing the URL and protocol.

  • What documentation changes (if any) are needed to support this PR?:

N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: David Beitey <david@davidjb.com>
@dschaper
Copy link
Member

dschaper commented Oct 1, 2022

I think this can go direct to master since it's meta and we won't tag it. A second PR should automatically merge it back to development.

@PromoFaux Can you give me a sanity check on that?

@PromoFaux
Copy link
Member

Yeah, fine to add meta commits to master

@PromoFaux PromoFaux changed the base branch from development to master October 1, 2022 13:27
@PromoFaux PromoFaux requested a review from a team October 1, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants