Fix pihole -r dialog exit

[rdwebdesign]

What does this PR aim to accomplish?

This PR fixes an error that happens if an user starts a repair (pihole -r) and decides to select exit option or press ESC. The script should exit, but it simply continues.

How does this PR accomplish the above?

Removing || true from the code.

What documentation changes (if any) are needed to support this PR?

none

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)

---

• I have read the above and my PR is ready for review. Check this box to confirm

[dschaper]

Can you show the tests you ran for this? I think this change will just trigger set -e and wont actually run the code that is intended to run when exit is selected.

[rdwebdesign]

I can't exit on the repair/reconfigure screen.
The script only exits on the other screens.

[rdwebdesign]

Look at the UpdateCmd (lines 2017-2025).
dialog is executed in a subshell.

pi-hole/automated install/basic-install.sh

Lines 2017 to 2027 in 7fd062c

	UpdateCmd=$(dialog --no-shadow --keep-tite --output-fd 1 \
	--cancel-label Exit \
	--title "Existing Install Detected!" \
	--menu "\\n\\nWe have detected an existing install.\
	\\n\\nPlease choose from the following options:\
	\\n($strAdd)"\
	"${r}" "${c}" 2 \
	"${opt1a}" "${opt1b}" \
	"${opt2a}" "${opt2b}" || true)
	result=$?

If dialog succeeds, the part before the || true will be execute and line 2027 will receive 0 (success).
If dialog exits with non-zero return, the || true is executed. Now, the last command was true. Line 2027 will receive 0 (success).

result=$? will always be 0.

[PromoFaux]

@rdwebdesign rebase

[rdwebdesign]

@rdwebdesign rebase

No comments... Do you think I'm a bot???

[dschaper]

Can you squash this first please?

[rdwebdesign]

Can you squash this first please?

Done.
Now it needs to be approved again.