Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused possibility to obfuscate pihole.log in debug log #4974

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 14, 2022

What does this PR aim to accomplish?:

Remove the unused obfucate pihole.log function from the debug log

See discussion: #4973


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Oct 14, 2022
@yubiuser yubiuser requested a review from a team October 14, 2022 06:37
@yubiuser yubiuser changed the title Remove unused possibility to obfuscate pihole.log Remove unused possibility to obfuscate pihole.log in debug log Oct 14, 2022
dschaper
dschaper previously approved these changes Oct 14, 2022
@dschaper dschaper added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Oct 14, 2022
@dschaper
Copy link
Member

Looks like the commit wasn't signed. I'd override the branch protection rule but that may cause issues going from dev to master for release.

@yubiuser
Copy link
Member Author

Thanks. I can also re-sing tomorrow. I cherry-picked from the other branch, maybe it got "lost"

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

Signed the commit, needs re-approval.

@yubiuser yubiuser added PR: Approval Required Open Pull Request, needs approval and removed PR: Approved Open Pull Request, Approved by required number of reviewers labels Oct 16, 2022
@DL6ER DL6ER merged commit e0c351f into development Oct 28, 2022
@DL6ER DL6ER deleted the no_obfuscation branch October 28, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants