Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused old code from gravity.sh #4985

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Remove unused old code from gravity.sh #4985

merged 2 commits into from
Oct 28, 2022

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Remove unused/dead code from gravity.sh, forgot after a modification, 3 years ago.

Context:
The first if block inside the function was commented, making the code unconditional.
After that edition, all code after the return 0 was never executed and became useless (but we kept updating it!)

How does this PR accomplish the above?

Removing the unused code.

What documentation changes (if any) are needed to support this PR?

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@yubiuser
Copy link
Member

Relevant PR: #2935

gravity.sh Outdated Show resolved Hide resolved
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign requested a review from a team October 17, 2022 18:35
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As being guilty for not removing it three years ago, I hereby approve.

@DL6ER DL6ER merged commit 7957acf into development Oct 28, 2022
@DL6ER DL6ER deleted the cleanup_gravity branch October 28, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants