Do not require man pages to be present in test script #5037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
We allow the installer to continue installation even when
mandb
or theman
directory is not present.pi-hole/automated install/basic-install.sh
Lines 1421 to 1429 in 21026d9
However, in the test suite, we only allow to skip the test for the man files in case
mandb
is not presentpi-hole/test/test_any_automated_install.py
Lines 211 to 213 in 21026d9
pi-hole/test/test_any_automated_install.py
Lines 291 to 320 in 21026d9
This PR allows to skip the man test also when the
man
directory (/usr/local/share/man
) is not present.Discovered while working on #5027
By submitting this pull request, I confirm the following:
git rebase
)