Use systemd in test containers

[yubiuser]

What does this PR aim to accomplish?:

PR #4924 added a native systemd service file. All our currently supported OS run systemd. However, during the automatic test suite we don't run systemd so far and mock systemctl call.

pi-hole/test/test_any_automated_install.py

Lines 172 to 181 in 0034538

	mock_command_2(
	"systemctl",
	{
	"enable lighttpd": ("", "0"),
	"restart lighttpd": ("", "0"),
	"start lighttpd": ("", "0"),
	"enable pihole-FTL": ("", "0"),
	"restart pihole-FTL": ("", "0"),
	"start pihole-FTL": ("", "0"),
	"*": ('echo "systemctl call with $@"', "0"),

Some images already require installation of an initsystem (e.g. centoOS and Fedora). This PR adds systemdas initsystem to the images so that the containers start with systemd as PID 1. This mimics the real-world OS situation better.

How does this PR accomplish the above?:

1. Adds the required systemd packages to the images.
2. Starts the test containers with --privileged instead of --cap-add=ALL (required to start systemd within the container) Uses podman instead of docker as container manager
3. Removes the mocked systemctl from the test suite.
4. Allows pihole restartdns to use systemctl instead of service if available. See this PR Allow pihole restart via systemctl #5045 for more details

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)
6. I have checked that another pull request for this purpose does not exist.
7. I have considered, and confirmed that this submission will be valuable to others.
8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
9. I give this submission freely, and claim no ownership to its content.

---

• I have read the above and my PR is ready for review. Check this box to confirm

[yubiuser]

I removed the mocked systemctl command in 8e6bb15. However, we could leave it in there and bypass it by checking if systemd is PID 1. This would keep the code in case we want to add a OS which is not using systemd as init system in the future.

[yubiuser]

I'll make a separate PR from 097e758. Just leaving it in here at the moment as it is a requirement for some OS to pass the test. I'll rebase once the other PR is merged.

---

Add:
PR #5045 failed the test and will always fail them until we remove/bypass the mock systemctl. I'll leave it in this PR then and amend the PR description.

[yubiuser]

Converting to draft until I've figured out why CentOS 8 needs 2:45h to pass the test on GH. Runs fine locally within 5 mins.

[PromoFaux]

According to the logs this is still taking a long time for Centos8 - have you got to the bottom of why?

[DL6ER]

Allows pihole restartdns to use systemctl instead of service if available

I don't think this is necessary as service is a wrapper. Do we really need this (complexity)?

[yubiuser]

I think yes, that's why I created the PR.

All distros use systemd by default, we have a native systemd unit now. Some container images already need an additional initsystem to pass the test (fedora, centos) - there is no service installed. Instead of installing sysVinit we should test with what is actually used by the distros.
Background of all of this: We use the service file (and now prestart.sh) to set file permissions and create files/folders. We check for them. So we need to start the scripts/service to set the permissions.

[yubiuser]

I just pushed the identical commits to a new branch and created PR #5057 and it finished in 4 minutes for CentOS8
https://github.com/pi-hole/pi-hole/actions/runs/3670895068/jobs/6205732893

[PromoFaux]

Maybe there was just something wrong a week ago and it just needed a kick today. I think we can close the other PR.

Do we really need this (complexity)?

One thing I do like here is that it removes some of the clusterfuck code in the tests that mocks systemctl, and anything we can do to make the tests easier to follow and maintain is a good thing in my book.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved.

[github-actions]

Conflicts have been resolved.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved.

[github-actions]

Existing merge conflicts have not been addressed. This PR is considered abandoned.