Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include mod_accesslog with new config #5121

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Prevents the following from occuring in the error log on fresh installs on debian-based distros (and by extension docker builds)

2023-01-16 10:20:01: configfile.c.1142) WARNING: unknown config-key: accesslog.filename (ignored)
2023-01-16 10:20:01: configfile.c.1142) WARNING: unknown config-key: accesslog.format (ignored)

This does not occur on upgrades because in those cases the old lighttpd.conf that we provided is not overwritten

pi-hole/docker-pi-hole#1273

Fedora/centos are unaffected

This could be fixed by running lighttpd-enable-mod accesslog in the docker container build script, but it is bound to show up here eventually.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

…es a warning to be flashed up in the error log. Enabling this

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux requested a review from a team January 16, 2023 13:37
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-web-v5-18-2-and-core-v5-15-1-released/60695/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants