-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable GRAVITY_TMPDIR variable into setupVars #5216
Conversation
Thanks for reviewing it, I think I've addressed all comments, let me know if there's any issue. Thank you! |
Thanks, can you squash and force please? |
Signed-off-by: Loïc Gomez <89980752+kot0dama@users.noreply.github.com>
Done and merged development branch again ;) |
I don't know if this solves #5168 but it's very relevant to that. |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-22-web-v5-19-and-core-v5-16-1-released/61999/1 |
Cool, that was fast ! |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pihole-tmp-no-space-left-on-device/61797/5 |
What does this PR aim to accomplish?:
This allows users to set up a Gravity updates temporary directory other than /tmp.
Indeed, some systems have a low amount of memory and some users might be reluctant to allocate too much memory to /tmp on these systems. You can look up the Internet for threads where people ask for a way to configure it.
How does this PR accomplish the above?:
I've added support for a GRAVITY_TMPDIR into gravity.sh, defaulting to /tmp if not configured, or if configured directory does not exist/is not a directory.
I've also added a default in the setup tool, I'm not sure that is the way to go though.
This way, users will be able to edit /etc/pihole/setupVars.conf and set/update GRAVITY_TMPDIR to the desired value.
This is probably unnecessary to add it as a step in the configurator though, but feel free to add it if it makes sense.
Link documentation PRs if any are needed to support this PR:
None
By submitting this pull request, I confirm the following:
git rebase
)