New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter ABP CSS selectors #5247
Merged
Merged
Filter ABP CSS selectors #5247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br> Signed-off-by: Christian König <ckoenig@posteo.de>
Co-authored-by: Adam Warner <me@adamwarner.co.uk> Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
I also removed the |
rdwebdesign
previously requested changes
Apr 7, 2023
Signed-off-by: Christian König <ckoenig@posteo.de>
…educe false positiv (deleting valid comments) Signed-off-by: Christian König <ckoenig@posteo.de>
yubiuser
force-pushed
the
filter_abp_extended
branch
from
April 8, 2023 12:59
71f5fab
to
dd3a7a4
Compare
PromoFaux
approved these changes
May 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Some ABP style lists contain lines with (extended) CSS selectors:
##
,#$#
,#?#
and#@#
Currently our code strips all comments from the input file, converting e.g.
good.com##bad-element
togood.com
leading to overblocking.This PR deletes lines with CSS selectors before stripping comments.
Fixes #5246
By submitting this pull request, I confirm the following:
git rebase
)