Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from query.sh #5266

Merged
merged 1 commit into from May 10, 2023
Merged

Remove unused code from query.sh #5266

merged 1 commit into from May 10, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented May 2, 2023

What does this PR aim to accomplish?:

Removes unused code from query.sh.

Within the scanList() function was a case selection for 3 different cases - however scanList()was only called once within query.sh - with regex passed as argument. This PR removed all but the regex case


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser marked this pull request as ready for review May 2, 2023 20:51
@yubiuser yubiuser requested a review from a team May 2, 2023 20:51
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label May 2, 2023
advanced/Scripts/query.sh Show resolved Hide resolved
@yubiuser yubiuser merged commit 8e5467d into development May 10, 2023
19 checks passed
@yubiuser yubiuser deleted the clean/query branch May 10, 2023 17:54
@DL6ER DL6ER mentioned this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants