Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to remove stale label on PRs #5292

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Do not try to remove stale label on PRs #5292

merged 3 commits into from
Sep 10, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented May 29, 2023

PR Master branch

What does this PR aim to accomplish?:

PR #5252 added the workflow to remove the 'stale' label from issues immediately when a stale issue received new comments. However, the github event issue_comment also triggers on PR comments (see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment).

As we don't handle stale PR with this workflow PR write permission is not granted and the workflow will fail (see https://github.com/pi-hole/pi-hole/actions/runs/5109474838/jobs/9184306155)

This PR adds an additional check to verify the action is not triggered by comments on pull requests. (see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment-on-issues-only-or-pull-requests-only)


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser changed the title Do not try to remove stale lables on PRs Do not try to remove stale label on PRs May 29, 2023
@yubiuser yubiuser requested a review from a team May 29, 2023 20:41
@yubiuser yubiuser marked this pull request as draft May 30, 2023 12:02
@yubiuser yubiuser marked this pull request as ready for review May 31, 2023 20:14
@yubiuser
Copy link
Member Author

Second commit should fix

Screenshot at 2023-05-31 21-58-01

Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser changed the base branch from development to master June 1, 2023 13:16
@yubiuser yubiuser added the PR: Master branch PR based on Master Branch label Jun 1, 2023
DL6ER
DL6ER previously approved these changes Jun 16, 2023
PromoFaux
PromoFaux previously approved these changes Jul 12, 2023
@PromoFaux PromoFaux requested a review from DL6ER July 12, 2023 20:42
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux
Copy link
Member

This was merged into other repos, not sure how I missed this one

@PromoFaux PromoFaux merged commit fef2861 into master Sep 10, 2023
17 checks passed
@PromoFaux PromoFaux deleted the fix/un_stale branch September 10, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PR: Master branch PR based on Master Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants