Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some verbiage change to outputs (plus a couple of comments) #5406

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Replaces some printed usages of white/blacklist with allow/deny as per other areas of the software.

Actually, thinking about it, we can probably pull out the legacy pre v5 file pointers/helpers now?


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team October 4, 2023 14:39
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux
Copy link
Member Author

The final commit is optional - but I think we can probably do away with this at this stage

@PromoFaux
Copy link
Member Author

Reverted the final pre-v5.0 migration commit for now. Probably needs addressing as part of a larger patch later

@PromoFaux PromoFaux merged commit 7b341cc into development-v6 Oct 4, 2023
15 checks passed
@PromoFaux PromoFaux deleted the wording branch October 4, 2023 18:49
@yubiuser
Copy link
Member

yubiuser commented Oct 8, 2023

Reverted the final pre-v5.0 migration commit for now. Probably needs addressing as part of a larger patch later

If we remove those migration steps, users still on v4 won't be able to upgrade to v6 (as they have no chance to get to v5 first once v6 is is 'master' everywhere). I'm not sure how many users will be affected, the number might be rather small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants