Set owner of gravity output files to pihole #5419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Fixes permission issues with downloaded list and
*.sha
files that occurs on v6. All files in/etc/pihole
should belong topihole
(See #5356). However, duringpihole -up
(which runs as root), the install script is called, which in turn runsgravity
from/opt/pihole
. All touched files will be owned byroot
afterwards.In contrast,
pihole -g
runs gravity aspihole
which causes issues atpi-hole/gravity.sh
Line 635 in 96640ea
How does this PR accomplish the above?:
Explicitly set the invoking user to
pihole
inbasic-install.sh
when running gravity. As the gravity run is one of the last things we do,pihole
should already be available.Additionally, this requires that that
/etc/pihole
is writable bypihole
already at that stage.By submitting this pull request, I confirm the following:
git rebase
)