Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chronometer #5423

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Remove Chronometer #5423

merged 3 commits into from
Oct 14, 2023

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Removes Chronometer. It's not compatible with v6 as the telnet API is removed. We have a good and working replacement with https://github.com/pi-hole/PADD


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-c-chronometer-throws-a-syntax-error/65510/3

@yubiuser yubiuser requested a review from a team October 12, 2023 11:47
@yubiuser yubiuser added PR: Approval Required Open Pull Request, needs approval Pi-hole v6.0 labels Oct 12, 2023
Signed-off-by: Christian König <ckoenig@posteo.de>
pihole Outdated Show resolved Hide resolved
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser merged commit 539f379 into development-v6 Oct 14, 2023
15 checks passed
@yubiuser yubiuser deleted the chronometer_good_by branch October 14, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pi-hole v6.0 PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants